Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modifier Manager #17143

Merged
merged 4 commits into from
Oct 23, 2018
Merged

[FEATURE] Modifier Manager #17143

merged 4 commits into from
Oct 23, 2018

Conversation

chadhietala
Copy link
Contributor

This is intended to implement RFC#373

@chadhietala chadhietala changed the title [WIP] Modifier Manager Modifier Manager Oct 23, 2018
rwjblue
rwjblue reviewed Oct 23, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, can you add a test for the non-string fallback version of setComponentManager?

@chadhietala chadhietala merged commit dec37c3 into master Oct 23, 2018
@chadhietala chadhietala deleted the modifier-managers branch October 23, 2018 17:29
@chadhietala chadhietala changed the title Modifier Manager [FEATURE] Modifier Manager Oct 23, 2018
@tomdale tomdale mentioned this pull request Nov 2, 2018
Closed
@knownasilya knownasilya mentioned this pull request Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chadhietala @rwjblue