-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX beta][FEAT] Adds a second dist build which targets IE #17188
Conversation
c60888e
to
cdf2ff0
Compare
build-metadata.json
Outdated
@@ -0,0 +1,6 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be checked in (maybe we should add it to .gitignore
?)
Oh, also can you update the commit message to start with |
cdf2ff0
to
e2d98ae
Compare
ALrighty, restructured to a better flow:
This flow ended up making the most sense to me given that we must do Anecdotally, the restructure does seem to be a bit slower, and there are some inconsistencies in the final builds. Specifically,
|
Hmm, I would not have expected the sizes to differ so much, would you mind attaching a .tar.gz of the |
Sure thing! |
e2d98ae
to
5aec3c4
Compare
I've been diffing the output bundles and while I haven't checked every single difference, a lot of them seem to come to a few categories:
Surprisingly, removing the
|
ec14cb9
to
df153d7
Compare
This PR adds a second dist to the build which targets IE. This allows the primary bundles to drop ES5 compilation from babel, and allows us to choose which bundles we want to use based on the consuming application's targets. In the long run, we want to actually enable consuming apps to build the Ember source code themselves. This is a temporary in-between measure to address a bug in native classes, in which users who do _not_ have IE as a build target cannot `.extend` from native classes due to conflicts in transpilation vs actual native class syntax.
df153d7
to
02af025
Compare
This PR adds a second dist to the build which targets IE. This allows
the primary bundles to drop ES5 compilation from babel, and allows us to
choose which bundles we want to use based on the consuming application's
targets.
In the long run, we want to actually enable consuming apps to build the
Ember source code themselves. This is a temporary in-between measure to
address a bug in native classes, in which users who do not have IE as
a build target cannot
.extend
from native classes due to conflictsin transpilation vs actual native class syntax.