[Feature] Update instance-initializer blueprint for ember-mocha 0.14 #17412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Turbo87
reviewed
Dec 28, 2018
| }); | ||
| afterEach(function() { | ||
| <% if (destroyAppExists) { %>destroyApp(this.application);<% } else { %>run(this.application, 'destroy');<% } %> | ||
| <% if (destroyAppExists) { %>destroyApp(this.instance);<% } else { %>run(this.instance, 'destroy');<% } %> |
There was a problem hiding this comment.
I would assume that the instance needs to be destroyed before the application.
@rwjblue thoughts?
There was a problem hiding this comment.
Yes, confirm, we should destroy the ApplicationInstance instance before the Application instance. (naming is hard 😭 )
There was a problem hiding this comment.
Updated this!
Here's a separate PR for QUnit: #17712
4 tasks
simonihmig
force-pushed
the
instance-init-mocha
branch
from
2c15d76
to
d072143
Compare
simonihmig
added a commit
to simonihmig/ember.js
that referenced
this pull request
Mar 6, 2019
simonihmig
added a commit
to simonihmig/ember.js
that referenced
this pull request
Mar 7, 2019
simonihmig
force-pushed
the
instance-init-mocha
branch
from
d072143
to
5b0b146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #16863
Note: this blueprint and the one for initializers (#17411) follow what the existing QUnit RFC232 blueprints do. However I wondered why for those qunit-based blueprints, the initializer test calls
setupTest(), while the instance-initializer does not. For now the two new PRs for ember-mocha 0.14 do the same, but if there is no good reason for this, I can update all of those...