Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] fix issue with overidability of computed.volatile #17431

Merged
merged 1 commit into from
Jan 5, 2019
Merged

[BUGFIX] fix issue with overidability of computed.volatile #17431

merged 1 commit into from
Jan 5, 2019

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Jan 5, 2019 •
edited
Loading

super.teardown was not called when computed is volatile, therefore was not torn down properly

@bekzod
Copy link
Contributor Author

bekzod commented Jan 5, 2019

fixes #17428

@bekzod bekzod mentioned this pull request Jan 5, 2019
Closed
@Turbo87 Turbo87 added the Bug label Jan 5, 2019
@rwjblue rwjblue merged commit 3bbb13f into emberjs:master Jan 5, 2019
@jordanbyron
Copy link

Thank you for the quick turn around 🤗

@bekzod
Copy link
Contributor Author

bekzod commented Jan 5, 2019 •
edited
Loading

fast and furious 💨💨

@bekzod bekzod deleted the fix-volatile-override branch January 5, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bekzod @jordanbyron @Turbo87 @rwjblue