[BUGFIX lts] support numbers in component names for Angle Brackets #17552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Feb 2, 2019
rwjblue
changed the title
Previously, c3-plot would not work when invoked as <C3Plot />. Now it will resolve correctly. Closes #17549
|
Done! Thanks for the tips on which files to look at to fix this. |
|
Hehe, well it was my fault to begin with so.... |
|
Thank you for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a component named
c3-plotwould not work when invoked as<C3Plot />.Now it will resolve correctly.
Closes #17549
Behavior:
Notably it does not support
Foo2bar => foo-2bar, but it did not support it before this change either.It's a bit edge-casey but I think given the prevalent use of C3 and D3 in JS, it makes sense to lean towards this patch's behavior.