[BUGFIX beta] Revert decorator refactors #17649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1c72067.
rwjblue
approved these changes
Feb 21, 2019
|
great |
bendemboski
pushed a commit
to bendemboski/ember-file-upload
that referenced
this pull request
Feb 26, 2019
`ember-concurrency` does not work with the current Ember beta, and it is used by `ember-addon-docs`. Until something like machty/ember-concurrency#277 makes `ember-concurrency` work again, or emberjs/ember.js#17649 is released to the beta channel to remove the breaking change, we need to allow failures in beta :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the recent decorators refactors on beta to unblock users of
ember-concurrencyand other addons as we polish up the implementation to land in 3.10. The reverted commits are: