[FEAT] Updates decorator implementation to stage 1 #17690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us back to stage 1 decorators for our internal decorator implementation. It also reverts to using a Symbol instead of a WeakMap for
@tracked
values. This is overall a better for perf, assuming we can assign the value of the symbol in the constructor via an initializer. Unfortunately stage 1 decorators don't allow this, but fortunately it should be very easy to add a babel transform specifically for@tracked
that does, so we can get the ideal performance.