[FEATURE EMBER_MODULE_UNIFICATION] Disable. #18066
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is extremely unlikely that the implementation of module unification that exists behind this feature flag will ever land, and due to the way we test optional features the presence of this feature flag makes it impossible to test other new features _without_ also testing module unification (meaning the features can't be tested independently). This disables the module unification feature completely such that it is not possible to enable at runtime.
chancancode
approved these changes
May 30, 2019
locks
approved these changes
May 30, 2019
|
😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is extremely unlikely that the implementation of module unification that exists behind this feature flag will ever land, and due to the way we test optional features the presence of this feature flag makes it impossible to test other new features without also testing module unification (meaning the features can't be tested independently).
This disables the module unification feature completely such that it is not possible to enable at runtime.