remove deprecated Location.create
#18127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
force-pushed
the
remove-location-api
branch
3 times, most recently
from
8005411
to
592fdb0
Compare
bekzod
force-pushed
the
remove-location-api
branch
from
592fdb0
to
aac9094
Compare
|
Should we continue to export the interface? While the implementation of |
|
I'm all for removing it. Just wanted to mention that I included this in the scope of my deprecate auto location RFC, so this PR will mark it as deprecated. As mentioned in this PR though, it would probably make just as much sense to remove it outright. Just wanted to comment here since my PR is related. I'm fine with both removing it right away as well as waiting for deprecation per my PR. |
|
Let's center the discussion in #19510. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since removal of
Ember.Location.registerImplementationin #11854 there is no public way registering location factory insideLocationso makesLocation.createredundant, if you still think it need deprecation warnings happy to add that instead