Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE ember-glimmer-set-component-template] Enable by default. #18198

Merged
merged 3 commits into from
Aug 1, 2019
Merged

[FEATURE ember-glimmer-set-component-template] Enable by default. #18198

merged 3 commits into from
Aug 1, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jul 12, 2019

As discussed in the 2019-07-12 Ember core team meeting.

@rwjblue
Copy link
Member Author

rwjblue commented Jul 13, 2019 

not ok 19 IE 11.0 - [71 ms] - Components test: setComponentTemplate:  calling it with primitives asserts
    ---
        actual: >
            false
        expected: >
            true
        stack: >
               at check (http://127.0.0.1:7774/408632652806/dist/legacy/ember-tests.js:104955:7)
               at expectAssertion (http://127.0.0.1:7774/408632652806/dist/legacy/ember-tests.js:104936:9)
               at testCallingItWithPrimitivesAsserts (http://127.0.0.1:7774/408632652806/dist/legacy/ember-tests.js:8831:13)
               at Anonymous function (http://127.0.0.1:7774/408632652806/dist/legacy/ember-tests.js:106187:11)
               at runTest (http://127.0.0.1:7774/408632652806/dist/qunit/qunit.js:3044:6)
               at run (http://127.0.0.1:7774/408632652806/dist/qunit/qunit.js:3030:6)
        message: >
            Expected Ember.assert to be called (Not called with any value).
        negative: >
            false
        browser log: |
    ...
pass count: 11898
skip 20 IE 11.0 - [0 ms] - Errors thrown during render: SKIPPED:  it can recover resets the transaction when an error is thrown during rerender

@chancancode
Copy link
Member

chancancode commented Jul 13, 2019 •
edited
Loading

Should enable the constant in the blueprint tests too 😄 nvm, that is in #18203

@chancancode chancancode force-pushed the enable-set-component-template branch from cf09c0e to 221a8c6 Compare July 31, 2019 22:16
@rwjblue rwjblue force-pushed the enable-set-component-template branch from 042c780 to 983fdac Compare July 31, 2019 22:49
rwjblue and others added 3 commits July 31, 2019 19:16
@rwjblue
[FEATURE ember-glimmer-set-component-template] Enable by default.
215b6de
@rwjblue @chancancode
Avoid assertions for Symbol when not present.
77b4bc6 
Co-authored-by: Godfrey Chan <[email protected]>
@rwjblue @chancancode
[BUGFIX beta] Reduce false positives for HAS_NATIVE_SYMBOL with polyf…
7a3175d 
…ills.

Prior to this change the core.js polyfills would be detected as "native
symbols" (they monkey patch `Object.prototype.toString` to avoid detection by
our prior check).

Co-authored-by: Godfrey Chan <[email protected]>
@rwjblue rwjblue force-pushed the enable-set-component-template branch from 983fdac to 7a3175d Compare July 31, 2019 23:16
@chancancode chancancode merged commit a1b5a6b into emberjs:master Aug 1, 2019
@kategengler kategengler mentioned this pull request Aug 1, 2019
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @chancancode