Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use esm for requiring default and deprecated features #18218

Closed
wants to merge 13 commits into from
Closed

use esm for requiring default and deprecated features #18218

wants to merge 13 commits into from

Commits on Jul 24, 2019

  1. attempt to use esm for requiring features 

    See emberjs/data#6231 (comment) for
the motivation.
    @eflanagan0
    eflanagan0 committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    c0e484a View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Update packages/@ember/canary-features/index.ts 

    Co-Authored-By: Robert Jackson <[email protected]>
    @efx @rwjblue
    efx and rwjblue authored Jul 25, 2019
    Configuration menu
    Copy the full SHA
    e2fd4b5 View commit details
    Browse the repository at this point in the history

  2. redeclare and export to fix typescript linting

    @eflanagan0
    eflanagan0 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    e2de50c View commit details
    Browse the repository at this point in the history

  3. add a loose declaration of default features hash

    @eflanagan0
    eflanagan0 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    fedf1d4 View commit details
    Browse the repository at this point in the history

  4. Update packages/@ember/canary-features/index.ts 

    Co-Authored-By: Robert Jackson <[email protected]>
    @efx @rwjblue
    efx and rwjblue authored Jul 25, 2019
    Configuration menu
    Copy the full SHA
    15cdeaa View commit details
    Browse the repository at this point in the history

  5. Update packages/@ember/canary-features/index.ts 

    Co-Authored-By: Robert Jackson <[email protected]>
    @efx @rwjblue
    efx and rwjblue authored Jul 25, 2019
    Configuration menu
    Copy the full SHA
    6a54e1a View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. tighten the type declaration for default features 

    Made a breakthrough reading https://basarat.gitbooks.io/typescript/content/docs/types/ambient/variables.html
    @eflanagan0
    eflanagan0 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    222e218 View commit details
    Browse the repository at this point in the history

  2. use esm for consuming deprecated features

    @eflanagan0
    eflanagan0 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    b3d35e6 View commit details
    Browse the repository at this point in the history

  3. merge with master 

    Add newly deprecated feature from #18214
    @eflanagan0
    eflanagan0 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    32695e2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into canary-feature-flags-esm

    @eflanagan0
    eflanagan0 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    63b9826 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. rename to index

    @eflanagan0
    eflanagan0 committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    95892c8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into canary-feature-flags-esm

    @eflanagan0
    eflanagan0 committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    9cd5c50 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. copy and paste to fix typescript errors 

    *I know not typescript*
This makes it work but now there are 2 copies of these flags in
`index.js` and `index.ts`. I am pushing up to avoid blocking and we can
consider a follow up PR or any intervening TS guidance to solve the
duplication.
    @eflanagan0
    eflanagan0 committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    6c02e4e View commit details
    Browse the repository at this point in the history