[DOC] Update documentation for EmberArray.any #18229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
requested changes
Aug 6, 2019
38 tasks
|
I am not understanding how a comment change in this file broke Blueprint tests in CI! |
|
@locks I reworded everything. see if it is better. I did a little paraphrasing from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some but I think it is different enough to prevent a license issue. |
Prior to this change, the wording was inaccurate. It was describing filtering not the short circuit behaviour of `any()`. This change attempts to fix that discrepancy and expand on the example to include both context option and arrow function use. Issue emberjs#18228
locks
changed the title
locks
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the wording was inaccurate. It was describing filtering not the short circuit behaviour of
any().This change attempts to fix that discrepancy and expand on the example to include both context option and arrow function use.
Issue #18228