Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix typos and simplify EmberArray definition #18237

Merged
merged 1 commit into from
Aug 16, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/@ember/-internals/runtime/lib/mixins/array.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,10 @@ function mapBy(key) {
concrete implementation, but it can be used up by other classes that want
to appear like arrays.

For example, ArrayProxy is a concrete classes that can
be instantiated to implement array-like behavior. Both of these classes use
the Array Mixin by way of the MutableArray mixin, which allows observable
changes to be made to the underlying array.
For example, ArrayProxy is a concrete class that can be instantiated to
implement array-like behavior. This class uses the Array Mixin by way of
the MutableArray mixin, which allows observable changes to be made to the
underlying array.

This mixin defines methods specifically for collections that provide
index-ordered access to their contents. When you are designing code that
Expand All @@ -203,8 +203,8 @@ function mapBy(key) {
as controllers and collections.

You can use the methods defined in this module to access and modify array
contents in a KVO-friendly way. You can also be notified whenever the
membership of an array changes by using `.observes('myArray.[]')`.
contents in an observable-friendly way. You can also be notified whenever
the membership of an array changes by using `.observes('myArray.[]')`.

To support `EmberArray` in your own class, you must override two
primitives to use it: `length()` and `objectAt()`.
Expand Down