Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Router#url should not error when location is a string #18267

Merged
merged 1 commit into from
Aug 16, 2019
Merged

[BUGFIX beta] Router#url should not error when location is a string #18267

merged 1 commit into from
Aug 16, 2019

Conversation

ryanolsonx
Copy link
Contributor

See: #18260

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2019

Hmm, I've restarted this CI job a couple of times and keep seeing the same failure.

@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2019

not ok 25 IE 11.0 - [35 ms] - {{on}} Modifier:  asserts if the provided callback accesses `this` without being bound prior to passing to on
    ---
        actual: >
            [object HTMLButtonElement]
        expected: >
            null
        stack: >
               at myFunc (http://127.0.0.1:7774/200750294740/dist/tests/ember-tests.js:41220:13)
        message: >
            this is null on browsers without native proxy support
        negative: >
            false
        browser log: |
    ...

@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2019

I can't figure out how that failure could be related to the changes here. 🤔

I think we need to get a test run in an actual IE11 box to see whats really going on (why does it pass on master, why does this seemingly unrelated change make it fail, etc).

@ryanolsonx
Copy link
Contributor Author

Yeah - that's pretty weird. I rebased on master and hopefully things just pass this next time around.

@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2019

Yep, that fixed things up for us. Thank you again @ryanolsonx!

@rwjblue rwjblue merged commit 41a8d31 into emberjs:master Aug 16, 2019
@ryanolsonx ryanolsonx deleted the bugfix/router-url-crash branch August 16, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants