[BUGFIX lts] Check the EMBER_ENV environment variable after it is set #18304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EMBER_ENV variable doesn't get set until addon hooks actually start running, so we weren't correctly determining the environment.
This comment has been minimized.
This comment has been minimized.
rwjblue
approved these changes
Aug 23, 2019
timiyay
pushed a commit
to timiyay/ember.js
that referenced
this pull request
Nov 27, 2019
The EMBER_ENV variable doesn't get set until addon hooks actually start running, so we weren't correctly determining the environment. Cherry-picked from PR emberjs#18304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EMBER_ENV variable doesn't get set until addon
hooks actually start running, so we weren't correctly
determining the environment.
Fixes #18294