Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update documentation for EmberArray.find #18324

Merged
merged 1 commit into from
Sep 1, 2019

Conversation

brunoocasali
Copy link
Contributor

Add code examples for EmberArray.find method.

Issue #18228

Add code examples for `EmberArray.find` method.

Issue emberjs#18228
@locks locks changed the title Update documentation for EmberArray.find [DOC] Update documentation for EmberArray.find Sep 1, 2019
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the help! 😁 I'll merge as soon as Browserstack gives us a green light.

@brunoocasali
Copy link
Contributor Author

@locks yeah, I couldn't "retry" the PR but ready to go now!
Next week I will send some more contributions :)

@locks locks merged commit 049a0bb into emberjs:master Sep 1, 2019
@locks
Copy link
Contributor

locks commented Sep 1, 2019

Keep them coming!

];

users.find((user) => user.name == 'Tom'); // [{ id: 2, name: 'Tom' }]
users.find(({ id }) => id == 3); // [{ id: 3, name: 'Melanie' }]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use ===

@brunoocasali brunoocasali deleted the patch-1 branch September 2, 2019 05:13
@locks locks mentioned this pull request Oct 26, 2019
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants