Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Added example for EmberArray#firstObject #18386

Merged
merged 1 commit into from
Sep 25, 2019
Merged

[DOC] Added example for EmberArray#firstObject #18386

merged 1 commit into from
Sep 25, 2019

Conversation

mukilane
Copy link
Contributor

For #18228

@mukilane
Copy link
Contributor Author

Can we add @readonly tag for firstObject?

@locks locks self-assigned this Sep 14, 2019
@locks
Copy link
Contributor

locks commented Sep 25, 2019

@mukilane I'm not sure we have @readonly anywhere at the moment, so let's get this merged and see about it separately :)

locks
locks approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

@locks locks merged commit 5117d1b into emberjs:master Sep 25, 2019
@locks locks mentioned this pull request Oct 26, 2019
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

Assignees

@locks locks

Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mukilane @locks @mukilan-e-8524