Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] #18228 Add description and example to EmberArray.getEach documentation #18464

Merged
merged 3 commits into from
Oct 26, 2019
Merged

[DOC] #18228 Add description and example to EmberArray.getEach documentation #18464

merged 3 commits into from
Oct 26, 2019

Conversation

Frozenfire92
Copy link
Contributor

#18228

Adds a description and example matching the mapBy documentation for EmberArray.getEach

locks
locks requested changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small request, thanks for the help :)

packages/@ember/-internals/runtime/lib/mixins/array.js Outdated Show resolved Hide resolved
locks
locks approved these changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you once again!

@locks locks merged commit 648c6c3 into emberjs:master Oct 26, 2019
@locks locks mentioned this pull request Oct 26, 2019
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frozenfire92 @locks