[BUGFIX release] Allows @each to work with arrays that contain falsy … #18477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
approved these changes
Oct 9, 2019
rwjblue
reviewed
Oct 9, 2019
| // should throw no errors | ||
| obj.falsyComputed; | ||
|
|
||
| assert.throws(() => { |
There was a problem hiding this comment.
Shouldn’t this be expectAssertion?
There was a problem hiding this comment.
Ah, correct, wonder why prod tests didn't catch that
…values This matches the original behavior as seen in the each_proxy.
pzuraq
force-pushed
the
bugfix/allow-each-towork-with-falsy-values
branch
from
8698e09
to
8efb331
Compare
|
Makes me worry that they are broken somehow 🤔 We should investigate... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…values
This matches the original behavior as seen in the each_proxy.
Fixes #18474