[DOC] add code example for EmberArray reject #18503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcfiredrill
changed the title
mcfiredrill
commented
Oct 23, 2019
| @@ -278,7 +278,7 @@ const ArrayMixin = Mixin.create(Enumerable, { | |||
|
|
|||
| ```javascript | |||
| let peopleToMoon = ['Armstrong', 'Aldrin']; | |||
|
|
|||
There was a problem hiding this comment.
Sorry for the noise, my editor removed the whitespace in this file.
There was a problem hiding this comment.
It's helpful, because those whitespaces shouldn't be there in the first place!
mcfiredrill
commented
Oct 23, 2019
38 tasks
locks
previously requested changes
Oct 23, 2019
| @@ -278,7 +278,7 @@ const ArrayMixin = Mixin.create(Enumerable, { | |||
|
|
|||
| ```javascript | |||
| let peopleToMoon = ['Armstrong', 'Aldrin']; | |||
|
|
|||
There was a problem hiding this comment.
It's helpful, because those whitespaces shouldn't be there in the first place!
Format array with one item per line Co-Authored-By: Ricardo Mendes <[email protected]>
RobbieTheWagner
suggested changes
Oct 24, 2019
| ]; | ||
| const nonFruits = food.reject(function(thing) { | ||
| return thing.isFruit; | ||
| }); // [{food: 'beans', isFruit: false}] |
There was a problem hiding this comment.
This should be bread not beans right?
There was a problem hiding this comment.
I suppose to be consistent with my other pull requests, yes. 🍞
There was a problem hiding this comment.
Ah sorry, I see my mistake now. I will fix it.
There was a problem hiding this comment.
Fixed here ed2fe07
RobbieTheWagner
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #18228