Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 8 support. #18785

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Drop Node 8 support. #18785

merged 1 commit into from
Feb 28, 2020

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Feb 28, 2020

Our public API around Node version support says:

To make it easier for us to deliver on our support promise we have adopted a policy that the HEAD of our master branches will be compatible with all versions of Node.js currently receiving support. For any Ember project on the day we drop support for a Node.js version the following things will happen:

  • We will update the engines key inside of package.json to specify the versions supported by the project.
  • We will update the testing targets to remove the newly-unsupported Node.js version from the list.
  • We will begin accepting code without testing it against the newly-unsupported version of Node.js.

For projects with an unspecified release model we will release one last version of the project prior to those steps. The version number change will reflect SemVer with respect to the APIs of the project and not take into consideration removal of Node.js version support. This means that the release may show up as a "patch" version release. For example, if we're dropping support for Node.js 0.10 and have a project at version 1.3.3 we can drop Node.js 0.10 support when we release version 1.3.4.

(from https://blog.emberjs.com/2016/09/07/ember-node-lts-support.html)

Our public API around Node version support says:

> To make it easier for us to deliver on our support promise we have
> adopted a policy that the HEAD of our master branches will be compatible
> with all versions of Node.js currently receiving support. For any Ember
> project on the day we drop support for a Node.js version the following
> things will happen:
>
> * We will update the engines key inside of package.json to specify the
>   versions supported by the project.
> * We will update the testing targets to remove the newly-unsupported
>   Node.js version from the list.
> * We will begin accepting code without testing it against the
    newly-unsupported version of Node.js.
>
> For projects with an unspecified release model we will release one last
> version of the project prior to those steps. The version number change
> will reflect SemVer with respect to the APIs of the project and not take
> into consideration removal of Node.js version support. This means that
> the release may show up as a "patch" version release. For example, if
> we're dropping support for Node.js 0.10 and have a project at version
> 1.3.3 we can drop Node.js 0.10 support when we release version 1.3.4.

(from https://blog.emberjs.com/2016/09/07/ember-node-lts-support.html)
@@ -95,13 +95,11 @@ jobs:
- yarn test

- name: Node.js Tests
node_js: "8"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default node_js is specified as 10 above, removing this line makes it use 10 instead of 8.

@rwjblue rwjblue merged commit d574096 into emberjs:master Feb 28, 2020
@rwjblue rwjblue deleted the drop-node-8 branch February 28, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants