Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Update glimmer-vm packages to 0.53.0 #18982

Merged
merged 2 commits into from
May 18, 2020

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented May 18, 2020

Full release notes here

Changes
#### :boom: Breaking Change
* `@glimmer/integration-tests`, `@glimmer/reference`, `@glimmer/runtime`, `@glimmer/validator`
	* [#1090](https://github.com/glimmerjs/glimmer-vm/pull/1090) Implement `@glimmer/tracking/primatives/cache` (see [emberjs/rfcs#615](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md) for details) ([@pzuraq](https://github.com/pzuraq))
* `@glimmer/validator`
	* [#1088](https://github.com/glimmerjs/glimmer-vm/pull/1088) Rename `memoizeTracked` to `memo` ([@pzuraq](https://github.com/pzuraq))
	* [#1089](https://github.com/glimmerjs/glimmer-vm/pull/1089) Remove unused EPOCH tag ([@pzuraq](https://github.com/pzuraq))

#### :rocket: Enhancement
* `@glimmer/integration-tests`, `@glimmer/reference`, `@glimmer/runtime`, `@glimmer/validator`
	* [#1090](https://github.com/glimmerjs/glimmer-vm/pull/1090) Implement `@glimmer/tracking/primatives/cache` (see [emberjs/rfcs#615](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md) for details) ([@pzuraq](https://github.com/pzuraq))

#### :bug: Bug Fix
* `@glimmer/compiler`
	* [#1102](https://github.com/glimmerjs/glimmer-vm/pull/1102) Add a compile time error when passing arguments to regular HTML elements (e.g. `<a @foo=`) ([@fivetanley](https://github.com/fivetanley))
* `@glimmer/integration-tests`, `@glimmer/reference`
	* [#1100](https://github.com/glimmerjs/glimmer-vm/pull/1100) Rerender an `{{#each`s block only when the specific item has changed ([@pzuraq](https://github.com/pzuraq))

#### :house: Internal
* [#1099](https://github.com/glimmerjs/glimmer-vm/pull/1099) Re-roll yarn.lock. ([@rwjblue](https://github.com/rwjblue))
* [#1098](https://github.com/glimmerjs/glimmer-vm/pull/1098) Remove .travis.yml ([@rwjblue](https://github.com/rwjblue))
* [#1096](https://github.com/glimmerjs/glimmer-vm/pull/1096) Add GitHub Actions ([@rwjblue](https://github.com/rwjblue))
* [#1097](https://github.com/glimmerjs/glimmer-vm/pull/1097) Remove bin/run-qunit.js test script. ([@rwjblue](https://github.com/rwjblue))
* [#1095](https://github.com/glimmerjs/glimmer-vm/pull/1095) Update release dependencies. ([@rwjblue](https://github.com/rwjblue))
* [#1094](https://github.com/glimmerjs/glimmer-vm/pull/1094) Update pinned Node version ([@rwjblue](https://github.com/rwjblue))
* [#1093](https://github.com/glimmerjs/glimmer-vm/pull/1093) Update pinned yarn version to 1.22.4. ([@rwjblue](https://github.com/rwjblue))

#### Committers: 3
- Chris Garrett ([@pzuraq](https://github.com/pzuraq))
- Robert Jackson ([@rwjblue](https://github.com/rwjblue))
- Stanley Stuart ([@fivetanley](https://github.com/fivetanley))

Fixes #18951
Fixes #18968

@rwjblue rwjblue added the Bug label May 18, 2020
@rwjblue rwjblue changed the title Update glimmer-vm packages to 0.53.0 [BUGFIX release] Update glimmer-vm packages to 0.53.0 May 18, 2020
@rwjblue
Copy link
Member Author

rwjblue commented May 18, 2020

$ tsc --noEmit
packages/@ember/-internals/glimmer/lib/component-managers/custom.ts(373,17): error TS2345: Argument of type 'CapturedArguments' is not assignable to parameter of type 'Cache<unknown>'.
  Property '[CACHE_KEY]' is missing in type 'CapturedArguments' but required in type 'Cache<unknown>'.
packages/@ember/-internals/glimmer/lib/component-managers/input.ts(73,44): error TS2345: Argument of type 'VersionedPathReference<unknown>' is not assignable to parameter of type 'Cache<unknown>'.
packages/@ember/-internals/glimmer/lib/helpers/action.ts(302,22): error TS2345: Argument of type 'VersionedPathReference<unknown>' is not assignable to parameter of type 'Cache<unknown>'.
  Property '[CACHE_KEY]' is missing in type 'VersionedPathReference<unknown>' but required in type 'Cache<unknown>'.
packages/@ember/-internals/glimmer/lib/helpers/action.ts(302,41): error TS2345: Argument of type 'VersionedPathReference<unknown>' is not assignable to parameter of type 'Cache<unknown>'.
packages/@ember/-internals/glimmer/lib/helpers/get.ts(101,15): error TS2345: Argument of type 'VersionedPathReference<unknown>' is not assignable to parameter of type 'Cache<unknown>'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants