[REFACTOR] Converts VM to use tracking internally #19093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
refactor/convert-to-autotracking
branch
2 times, most recently
from
16573cf
to
219e5f0
Compare
rwjblue
reviewed
Aug 19, 2020
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
Outdated
Show resolved
Hide resolved
pzuraq
force-pushed
the
refactor/convert-to-autotracking
branch
from
219e5f0
to
d142f98
Compare
rwjblue
reviewed
Aug 19, 2020
| ): InputComponentState { | ||
| assert('caller must be const', isConstTagged(caller)); | ||
| // assert('caller must be const', isConstTagged(caller)); |
There was a problem hiding this comment.
We should either delete, or bring this back...
rwjblue
reviewed
Aug 19, 2020
Comment on lines
301
to
302
| // } else if (isConstTagged(target) && isConstTagged(action)) { | ||
| // fn = makeClosureAction(context.value(), target.value(), action.value(), processArgs, debugKey); |
There was a problem hiding this comment.
Should either delete or bring back
pzuraq
force-pushed
the
refactor/convert-to-autotracking
branch
from
d142f98
to
ba16712
Compare
rwjblue
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates glimmerjs/glimmer-vm#1115