Fix rendering engine usage within a fastboot sandbox
#19124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this we were simulating FastBoot in a non-isolated VM context. That meant that the running Node context was available within rendering attempts. However, when ran with "real" FastBoot that is **not** the case. In the real FastBoot environment, we create an isolated `vm` context and evaluate both Ember and the application within that context. This ensures that the running context does not have access to arbitrary Node-land APIs (e.g. `require`). (cherry picked from commit f9ef7dc)
rwjblue
force-pushed
the
fix-fastboot-beta
branch
from
e49d32b
to
084361a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the test from #19123 and the fixes from glimmerjs/glimmer-vm#1155 to the
betabranch.Fixes glimmerjs/glimmer-vm#1141
Fixes #19113