[RFC 673] Deprecate tryInvoke #19254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
force-pushed
the
deprecate-try-invoke
branch
from
fa39a3b
to
5ca044b
Compare
rwjblue
requested changes
Nov 11, 2020
packages/@ember/-internals/glimmer/tests/integration/components/life-cycle-test.js
Outdated
Show resolved
Hide resolved
locks
force-pushed
the
deprecate-try-invoke
branch
from
5ca044b
to
9eb8f7f
Compare
locks
force-pushed
the
deprecate-try-invoke
branch
from
9eb8f7f
to
fbd50d3
Compare
|
@rwjblue code corrected! |
rwjblue
reviewed
Nov 12, 2020
This ensures a new enough `@babel/preset-env` that includes `@babel/plugin-syntax-optional-chaining`.
locks
force-pushed
the
deprecate-try-invoke
branch
from
d04b873
to
15e3eb2
Compare
|
@rwjblue good catch! I should've thought of that as I just had this problem in an app this week 😂 FYI for anyone running into this, you need |
Nah. Having separate commits is great, when they each do something logical. |
rwjblue
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements RFC #673 "Deprecate tryInvoke".
Deprecation guide PR.
There seemed to be some internal usage of
tryInvoke, so I exported an underscored tryInvoke for internal usage, and call it from the public tryInvoke.I retrieved the deprecation URL from the preview, which should only change if the id changes.