[BUGFIX] Rename private runloop functions #19466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently export a few private functions from `@ember/runloop` for packages like `@ember/test-helpers`. These functions are not public API, but need to be accessible for these core packages. Previously they were exposed on the private APIs of the global `run`, but now that we're getting rid of the the modules transform these are now exposed directly, so underscoring them should help make users aware that they are not meant for public consumption.
pzuraq
force-pushed
the
bugfix/rename-private-runloop-methods
branch
from
5032767
to
aece1dc
Compare
rwjblue
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently export a few private functions from
@ember/runloopforpackages like
@ember/test-helpers. These functions are not public API,but need to be accessible for these core packages. Previously they were
exposed on the private APIs of the global
run, but now that we'regetting rid of the the modules transform these are now exposed directly,
so underscoring them should help make users aware that they are not
meant for public consumption.