[BUGFIX release] Prevent eager argument consumption on modifier destruction #19469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades the VM to include the fix for eager argument consumption on modifier destruction. Fixes #19131
|
@pzuraq - Is this just for canary, or should we backport to release? |
pzuraq
changed the title
|
We can backport this to release, for 3.24 and 3.20 LTS it'll have to be a different bugfix altogether because the VM was different back then. Luckily this code was in Ember at that time, so should be pretty easy to fix. |
rwjblue
approved these changes
Mar 19, 2021
|
Perhaps also fixes #19447? |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the VM to include the fix for eager argument consumption on
modifier destruction.
Fixes #19131 on canary