Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix computed import deprecation import path #19536

Merged
merged 1 commit into from
May 24, 2021
Merged

fix computed import deprecation import path #19536

merged 1 commit into from
May 24, 2021

Conversation

knownasilya
Copy link
Contributor

This is the current message:

deprecate.js:136 DEPRECATION: Using `computed.oneWay` has been deprecated. Instead, import the value directly from @ember/object/computed:

  import { oneWay } from '@ember/runloop';

Notice how it should not be runloop

@knownasilya knownasilya changed the title fix computed deprecation import path fix computed import deprecation import path May 6, 2021
rwjblue
rwjblue approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eeeck! Thank you for fixing this @knownasilya!

@rwjblue rwjblue merged commit 8662ed6 into emberjs:master May 24, 2021
@knownasilya knownasilya deleted the patch-8 branch May 24, 2021 16:41
@locks locks mentioned this pull request Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knownasilya @rwjblue @chancancode