-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP] Remove jQuery integration in EventDispatcher #19552
[CLEANUP] Remove jQuery integration in EventDispatcher #19552
Conversation
Ok, so there are 4 failings tests for IE11. These are all related to the also deprecated moveEnter/Leave events. They fail due to the inability to override Again, we cannot fix this behavior in IE11, and as these events are deprecated anyway, it seems unreasonable to spend more time on fixing/disabling those tests here. The removal of support for these events if already underway in #19529 (/cc @btecu), so I would suggest we try to land this first, and then rebase this PR which should then make CI happy. |
We probably should have a separate PR removing IE11 from CI. Once we start landing breaking changes on canary, we won't need to support IE11 anymore (as it's deprecated in 4.0), so no need to test against it. |
I wondered about this, so when actually is this going to happen? The package.json in |
@simonihmig yeah I'm trying to figure this out now. I think what could possibly happen is, we start landing the cleanup/fixes for 4.0 on canary and move forward. If we do end up needing to have another 1-2 releases after 3.28, we could re-release the 3.28 LTS and continue supporting it on a different branch. We've done this before when a beta was particularly unstable and we had to push it back, so I think we could do something similar here if we needed to, but I want to get consensus from the rest of the team about that. |
Due to some complications with 3.27's migration to use real modules (and the resulting massive number of deprecations being triggered) we are not 100% certain (yet) that 4.0 will be the version just after v3.28. In order to move ahead with v4.0 cleanup efforts (like this one), I've pushed a new branch that can serve as the target for breaking change PR's: https://github.com/emberjs/ember.js/tree/v4-cleanup. I've updated this PR to target that branch, can you rebase against that branch and push an update? Expand for an example of the commands needed for that rebase.
Those steps should be roughly what you need, but might need some tweaks based on your local repository setup (e.g. if you don't use Thank you for helping us push things forward! |
dce4061
to
6753f42
Compare
Done |
OK, I think we need another rebase to drop IE11 from the browser stack setup and then this should be good, right? |
6753f42
to
c452cdc
Compare
@rwjblue yep, did that, green now! |
@simonihmig this PR was auto-closed when v4-cleanup was merged to master. Can you re-open for us to review/merge against master? This is excellent work and I don't want to lose it. |
Second part after #19551 to remove deprecations of RFC386.