[BUGFIX release] Improve class based tranform deprecation message #19555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
commented
May 25, 2021
| @@ -102,28 +107,29 @@ function wrapLegacyPluginIfNeeded(_plugin: PluginFunc | LegacyPluginClass): Plug | |||
| let pluginInstantiated = false; | |||
|
|
|||
| return { | |||
| name: _plugin.constructor && _plugin.constructor.name, | |||
| name: plugin.name, | |||
There was a problem hiding this comment.
Pretty sure this was a bug previously: if plugin is a class, then plugin.constructor would have been Function, so this would always be the string "Function".
There was a problem hiding this comment.
(Hopefully the name wasn't used to deduplicate plugins!)
chancancode
force-pushed
the
class-based-transform-deprecation
branch
from
42c0b83
to
e28a201
Compare
wagenet
approved these changes
May 25, 2021
rwjblue
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was quite difficult to track down since it doesn't tell you which plugin is causing the issue. It only reports the name of the template which is not actually relevant.