[DONT BACKPORT][BUGFIX lts] Ensures that computed can depend on dynamic hash keys #19565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that computeds can depend on dynamic hash keys that did not exist on the original hash.
pzuraq
force-pushed
the
bugfix/ensure-hash-works-with-computeds
branch
from
167be20
to
628a928
Compare
rwjblue
approved these changes
May 27, 2021
pzuraq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that computeds can depend on dynamic hash keys that did not
exist on the original hash.
Depends on: glimmerjs/glimmer-vm#1318
Fixes: #19562
This PR/fix ended up not working out, so we're not backporting