Remove for and since deprecations from deprecate method #19627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
approved these changes
Jul 17, 2021
| }); | ||
| } | ||
| assert(missingOptionsForDeprecation(options!.id), Boolean(options!.for)); | ||
| assert(missingOptionsSinceDeprecation(options!.id), Boolean(options!.since)); |
There was a problem hiding this comment.
Seems inconsistent that these asserts bother to include the deprecation id and the earlier asserts do not.
There was a problem hiding this comment.
Yeah I wasn't sure why, but seems like good so I left it
|
@nlfurniss this PR was auto-closed when v4-cleanup was merged to master. Can you re-open for us to review/merge against master? This is excellent work and I don't want to lose it. |
|
Replaced by #19643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19617
TEST_SUITE=all yarn testpasses locally