Add deprecation warning to Ember.assign #19634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
requested changes
Jul 17, 2021
| @@ -49,7 +49,9 @@ moduleFor( | |||
| 'Ember.assign (polyfill)', | |||
| class extends AssignTests { | |||
| assign() { | |||
| return assignPolyfill(...arguments); | |||
| return expectDeprecation(() => { | |||
There was a problem hiding this comment.
Suggested change
| return expectDeprecation(() => { | |
| expectDeprecation(() => { |
If we can safely discard the return value of assignPolyfill's result, then we simply don't need a return value.
|
Also, I believe we need someone to commit to writing the deprecation guide in the next few weeks (before the beta cut) in order to land this. It seems like we need 4.x section in the guides app ember-learn/deprecation-app#898 |
|
@nlfurniss this PR was auto-closed when v4-cleanup was merged to master. Can you re-open for us to review/merge against master? This is excellent work and I don't want to lose it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember RFC #750 was approved; this implements it.
The
urlfor the deprecation is optimistic (in that that page does not yet exist), let me know if I should handle that differently.