Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning to Ember.assign #19649

Merged
merged 2 commits into from
Aug 1, 2021
Merged

Add deprecation warning to Ember.assign #19649

merged 2 commits into from
Aug 1, 2021

Conversation

nlfurniss
Copy link
Contributor

Ember RFC #750 was approved; this implements it.

The url for the deprecation is optimistic (in that that page does not yet exist), let me know if I should handle that differently.

@nlfurniss
Copy link
Contributor Author

Rebased and pushed. Not sure why lint failed on a file I didn't edit 🤨

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small tweak here, but I'd love another PR that actually removes the implementation in packages/@ember/polyfills/lib/assign.ts. Now that we only support browsers that include Object.assign we can basically do:

export default Object.assign;

(also removing the babel-plugin-transform-object-assign usage)

packages/@ember/deprecated-features/index.ts Outdated Show resolved Hide resolved
@nlfurniss
Copy link
Contributor Author

nlfurniss commented Jul 21, 2021

Only one small tweak here, but I'd love another PR that actually removes the implementation in packages/@ember/polyfills/lib/assign.ts. Now that we only support browsers that include Object.assign we can basically do:

export default Object.assign;

(also removing the babel-plugin-transform-object-assign usage)

Added that here, since it seems like it should be in one PR, but happy to move if you'd like.

and the babel transform was removed in #19563

@mixonic
Copy link
Member

mixonic commented Aug 1, 2021

Looks good to me. I rebased to resolve a conflict and force pushed.

@mixonic mixonic merged commit 560751f into emberjs:master Aug 1, 2021
@mydea mydea mentioned this pull request Aug 2, 2021
@nlfurniss nlfurniss deleted the deprecate-ember-assign branch August 21, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants