[CLEANUP] Cleanup IE11 leftovers #19667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After dropping IE11 support, all supported browsers support symbols natively.
After dropping IE11 support, all supported browsers support proxies natively.
simonihmig
commented
Jul 19, 2021
| @@ -10,7 +10,7 @@ import Route from '../system/route'; | |||
| import EmberRouter, { QueryParam } from '../system/router'; | |||
| import { extractRouteArgs, resemblesURL, shallowEqual } from '../utils'; | |||
|
|
|||
| const ROUTER = symbol('ROUTER') as string; | |||
| const ROUTER = (symbol('ROUTER') as unknown) as string; | |||
There was a problem hiding this comment.
Following up on #19575 (comment):
I get this TS error in my branch without it:
This comes from the change in https://github.com/emberjs/ember.js/pull/19667/files#diff-8519bc32ded2c3feefab86f01e1308398bacc99f2c10d4b28d372c0853d33203. The type of the exported symbol changed there, as the return type of the function is now always a native symbol (was string | symbol before).
|
Thank you @simonihmig ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened #19575