Remove deprecated disabledWhen #19669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Jul 21, 2021
|
Eh, I was just about to comment we probably want to wait on all of these features related to link-to and do them together. The idea is we should be able to just remove |
This was referenced Jul 22, 2021
mixonic
added a commit
to mixonic/ember.js
that referenced
this pull request
Nov 4, 2021
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review emberjs#19669 and ensure all `disabledWhen` is removed. * Review emberjs#19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts
mixonic
added a commit
to mixonic/ember.js
that referenced
this pull request
Nov 4, 2021
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review emberjs#19669 and ensure all `disabledWhen` is removed. * Review emberjs#19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts
mixonic
added a commit
to mixonic/ember.js
that referenced
this pull request
Nov 4, 2021
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review emberjs#19669 and ensure all `disabledWhen` is removed. * Review emberjs#19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts
mixonic
added a commit
to mixonic/ember.js
that referenced
this pull request
Nov 4, 2021
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review emberjs#19669 and ensure all `disabledWhen` is removed. * Review emberjs#19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts
mixonic
added a commit
to mixonic/ember.js
that referenced
this pull request
Nov 8, 2021
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review emberjs#19669 and ensure all `disabledWhen` is removed. * Review emberjs#19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts
mixonic
added a commit
to mixonic/ember.js
that referenced
this pull request
Nov 8, 2021
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review emberjs#19669 and ensure all `disabledWhen` is removed. * Review emberjs#19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts
mixonic
added a commit
to mixonic/ember.js
that referenced
this pull request
Nov 9, 2021
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review emberjs#19669 and ensure all `disabledWhen` is removed. * Review emberjs#19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts
mixonic
added a commit
to mixonic/ember.js
that referenced
this pull request
Nov 9, 2021
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review emberjs#19669 and ensure all `disabledWhen` is removed. * Review emberjs#19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts
kategengler
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review #19669 and ensure all `disabledWhen` is removed. * Review #19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts (cherry picked from commit 5d24ae7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrected this from the previous PR tracking v4-cleanup.
Part of #19617
All
link-totests, including ones settingdisabledpass locally.