[ci]: @ember/test-helpers partner test #19728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
sn/ci-partner
branch
2 times, most recently
from
796e676
to
76a5b30
Compare
snewcomer
force-pushed
the
sn/ci-partner
branch
from
76a5b30
to
177b3f1
Compare
snewcomer
force-pushed
the
sn/ci-partner
branch
from
177b3f1
to
8e44598
Compare
snewcomer
force-pushed
the
sn/ci-partner
branch
from
8e44598
to
4391273
Compare
snewcomer
force-pushed
the
sn/ci-partner
branch
3 times, most recently
from
2b51bec
to
95cf534
Compare
|
@stefanpenner This is ready for your review! cc @rwjblue |
snewcomer
force-pushed
the
sn/ci-partner
branch
2 times, most recently
from
86d0913
to
993ae85
Compare
snewcomer
force-pushed
the
sn/ci-partner
branch
from
71fca81
to
62201b0
Compare
5 tasks
snewcomer
force-pushed
the
sn/ci-partner
branch
2 times, most recently
from
b4b367b
to
67990ba
Compare
|
@stefanpenner Just a friendly ping. This is ready for your review based on our discussion here - #19680 (comment) |
snewcomer
force-pushed
the
sn/ci-partner
branch
from
131f7a1
to
b9a2a43
Compare
|
Is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #19680 (comment)
This PR adds smoke tests for ember-test-helpers, ember-string and ember-legacy-built-in-components when a PR is opened to ensure no regressions in those repos.