Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP beta] remove addArrayObserver #19746

Closed
wants to merge 1 commit into from
Closed

[CLEANUP beta] remove addArrayObserver #19746

wants to merge 1 commit into from

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Sep 7, 2021 •
edited by mixonic
Loading

@snewcomer snewcomer force-pushed the sn/rm-array-observer branch 3 times, most recently from b9d2b32 to 70ba04a Compare September 7, 2021 13:00
@mixonic mixonic mentioned this pull request Nov 5, 2021
Closed
58 tasks
@mixonic mixonic changed the title [CLEANUP]: remove addArrayObserver [CLEANUP beta] remove addArrayObserver Nov 11, 2021
@mixonic mixonic mentioned this pull request Nov 12, 2021
Merged
@mixonic
Copy link
Member

mixonic commented Nov 12, 2021

@snewcomer I believe we've gotten a version of this green in #19833. There is definitely further work, and this PR was extremely helpful as a roadmap for what the scope of changes would be. In general in the other PR I did try to be as conservative as possible about changes, even so I ran into some gnarly leaky interfaces.

Thank you for getting this going! Your review on the other PR would be very helpful.

@mixonic mixonic closed this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4.0 Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snewcomer @mixonic @kategengler