Fix memory leak when looking up non-instantiable objects from the owner #19820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisselden
force-pushed
the
fix-memory-leak
branch
from
28da241
to
4112c33
Compare
rwjblue
reviewed
Nov 3, 2021
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced by #19467 which was merged into https://github.com/emberjs/ember.js/releases/tag/v3.27.0-beta.1
Before that PR moved where the back ref to the factory was created, it was only set if instantiate flag was true. After that PR moved where this was done, it would set the back ref on instantiate false, leaking the owner onto things like static template imports.
This isn't a big deal when there is only one app instance, but it is a problem in Fastboot and Acceptance tests.