Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Remove Ember.Component.reopen #19831

Closed
wants to merge 1 commit into from
Closed

[CLEANUP beta] Remove Ember.Component.reopen #19831

wants to merge 1 commit into from

Conversation

SergeAstapov
Copy link
Contributor

Part of #19617

@SergeAstapov
Copy link
Contributor Author

There is related #19664 for the same removal but in built-in components

@SergeAstapov
Copy link
Contributor Author

@mixonic looks like it's done as part of #19806 - would you like to have a small targeted PR or it does not make sense?

@mixonic
Copy link
Member

mixonic commented Nov 9, 2021

@SergeAstapov we would like it to be one big PR, I think. This is because the removed components and much of their capability (like reopen) should all be contained within emberjs/ember-legacy-built-in-components#1. Component.reopen itself should be removed and I think will not be in emberjs/ember-legacy-built-in-components#1, but regardless I think the codepaths are likely tangled enough we should do it in a single go.

I'll review this PR to make sure I'm pulling these same things out in #19806.

Thank you for this work though, it will be a helpful reference and good gut check.

@SergeAstapov
Copy link
Contributor Author

@mixonic thank you for explanation! Feel free to close this PR once it's not needed (I wasn't sure was doing all things right way anyways, at least CI was happy)

@mixonic mixonic closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants