Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP beta] Turn template-only-glimmer-components deprecation into an error #19836

Merged
merged 1 commit into from
Nov 12, 2021
Merged

[CLEANUP beta] Turn template-only-glimmer-components deprecation into an error #19836

merged 1 commit into from
Nov 12, 2021

Conversation

bertdeblock
Copy link
Member

Part of #19617.

@bertdeblock
Copy link
Member Author

/cc @mixonic.

@bertdeblock
Copy link
Member Author

@rwjblue Is the failing Browser Tests (Firefox) check related to my changes? They seem to run fine locally.

@mixonic
Copy link
Member

mixonic commented Nov 12, 2021

@bertdeblock I'm re-running now

@rwjblue rwjblue merged commit 017b11e into emberjs:master Nov 12, 2021
@mixonic
Copy link
Member

mixonic commented Nov 12, 2021

Thank you @bertdeblock !

@kategengler kategengler mentioned this pull request Nov 15, 2021
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertdeblock @mixonic @rwjblue