[CLEANUP beta] Inelegant throw for arg-less-paren-less helper #19843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19617
Convert the deprecation for
argument-less-helper-paren-less-invocation
into athrow
. A more elegant version of this fix would convert the deprecation upstream in Glimmer VM into an assert, or would update the syntax to match a more desired functionality. I've taken a quick stab at that, but wasn't able to come up with something I was happy with quickly.I suggest we land this for 4.0, and we can continue to improve the message in the
throw
, or remove thethrow
, or add anassert
instead at the Glimmer VM level, in followup patches.