Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Inelegant throw for arg-less-paren-less helper #19843

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

mixonic
Copy link
Member

@mixonic mixonic commented Nov 14, 2021

Part of #19617

Convert the deprecation for argument-less-helper-paren-less-invocation into a throw. A more elegant version of this fix would convert the deprecation upstream in Glimmer VM into an assert, or would update the syntax to match a more desired functionality. I've taken a quick stab at that, but wasn't able to come up with something I was happy with quickly.

I suggest we land this for 4.0, and we can continue to improve the message in the throw, or remove the throw, or add an assert instead at the Glimmer VM level, in followup patches.

@mixonic mixonic marked this pull request as ready for review November 14, 2021 20:22
@mixonic mixonic mentioned this pull request Nov 14, 2021
58 tasks
@mixonic
Copy link
Member Author

mixonic commented Nov 14, 2021

I'm taking @rwjblue's approval and merging. I have opened an issue upstream in Glimmer-VM for the cleanup to either improve this error message or change functionality. See glimmerjs/glimmer-vm#1363

@chancancode I would still value your opinion, and I'm happy to do some more followup if you think it is critical for 4.0.

@mixonic mixonic merged commit acdd8ea into emberjs:master Nov 14, 2021
@mixonic mixonic deleted the mixonic/dumb-assert branch November 14, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants