Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX 3.28] Improve implicit injections deprecation for routes #19854

Merged
merged 1 commit into from
Nov 30, 2021
Merged

[BUGFIX 3.28] Improve implicit injections deprecation for routes #19854

merged 1 commit into from
Nov 30, 2021

Commits on Nov 30, 2021

  1. Improve implicit injections deprecation for routes 

    The store property on routes uses a setter, and so was not impacted by
the implicit-injections deprecation issued elsewhere. This may lead app
or addon authors to miss usage of a deprecated store injection on the
road to 4.0.

This improvement of the deprecation fidelity means libraries which use
the type injection system to define a store, like Ember Data, should
consider another approach to maintain any undeprecated API (for example
reopening the route class).
    @mixonic
    mixonic committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    c9e0abe View commit details
    Browse the repository at this point in the history