Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for @ember/component #19953

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Docs for @ember/component #19953

merged 4 commits into from
Dec 12, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

No description provided.

@NullVoxPopuli NullVoxPopuli mentioned this pull request Feb 10, 2022
Closed
21 tasks
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review February 10, 2022 16:32
chriskrycho
chriskrycho reviewed Feb 10, 2022
View reviewed changes
packages/@ember/component/index.ts Outdated
*
* For a full list of capabilities, their defaults, and how they are used, see [@glimmer/manager](https://github.com/glimmerjs/glimmer-vm/blob/4f1bef0d9a8a3c3ebd934c5b6e09de4c5f6e4468/packages/%40glimmer/manager/lib/public/component.ts#L26)
*
* @param {'3.4' | '3.13'} managerApiVersion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this has to be 3.13 for Ember v4?

chriskrycho
chriskrycho reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for opening this!

@NullVoxPopuli NullVoxPopuli changed the title Add docs for low-level apis (and new apis since 3.25) Docs for @ember/component Feb 10, 2022
@NullVoxPopuli
Copy link
Contributor Author

is there a way to preview the api docs?

@wagenet
Copy link
Member

wagenet commented Feb 10, 2022

Might be some overlap with #19948.

@chriskrycho
Copy link
Contributor

@NullVoxPopuli mind rebasing this and addressing the comment above? (The rebase doesn’t look strictly necessary but given the amount of change it’d make me more confident in the results here!)

@NullVoxPopuli
Copy link
Contributor Author

@chriskrycho done. thanks!

chriskrycho
chriskrycho requested changes Apr 6, 2022
View reviewed changes
packages/@ember/component/index.ts Outdated Show resolved Hide resolved
packages/@ember/component/index.ts Outdated Show resolved Hide resolved
packages/@ember/component/index.ts Outdated Show resolved Hide resolved
packages/@ember/component/index.ts Outdated Show resolved Hide resolved
@chriskrycho
Copy link
Contributor

@NullVoxPopuli still interested in landing these docs updates?

@NullVoxPopuli
Copy link
Contributor Author

@chriskrycho updated!

@locks
Copy link
Contributor

locks commented Aug 4, 2023

@NullVoxPopuli is this still relevant?

@NullVoxPopuli
Copy link
Contributor Author

Yup

@NullVoxPopuli
Copy link
Contributor Author

Ember helper is also missing a bunch of docs

@kategengler
Copy link
Member

@NullVoxPopuli If this is still relevant, do you want to update it?

@NullVoxPopuli
Copy link
Contributor Author

Yes, this documentation has been missing for a long time 🙃 update incoming

@kategengler
Copy link
Member

Enabled auto-merge, thank you!

auto-merge was automatically disabled December 12, 2023 19:41

Head branch was pushed to by a user without write access

@kategengler kategengler merged commit 0f36fec into emberjs:main Dec 12, 2023
16 of 17 checks passed
@NullVoxPopuli NullVoxPopuli deleted the document-setComponentTemplate branch December 12, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NullVoxPopuli @wagenet @chriskrycho @locks @kategengler