-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate types for the warn
method
#20224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this! One small tweak needed on the TS, and in fact this helps us catch an error in what the types here allowed!
@emberjs/typescript-core is this relevant? |
It should be OK to merge with @chriskrycho's suggestions. |
Mention the `id` parameter in the options object.
Co-authored-by: Chris Krycho <[email protected]>
I rebased and it turns out we'd already integrated most of the changes in other PRs. That said, there are some documentation improvements here that we could merge in. |
Enabled auto-merge! |
This PR consist of two commits (if they are okay, I can them squash them)
id
property in the options object of thewarn
method. Thedeprecate
method mentions the sub-options properties and I tried to align the doc's for the warn method.warn
method. Right now, thetest
parameter can be used as atest
-condition or as a shortcut for theoptions
object to always display the warning. Theoptions
object itself is required for the warning.What do you think?