[DOC] Add missing closing bracket in RouterService docs
#20276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Nov 22, 2022
| @@ -454,12 +454,12 @@ class RouterService<R extends Route> extends Service.extend(Evented) { | |||
| import Route from '@ember/routing'; | |||
| import { service } from '@ember/service'; | |||
|
|
|||
| export default class extends Route { | |||
| export default class ContactFormRoute extends Route { | |||
There was a problem hiding this comment.
So it matches the output of ember g route contact-form.
There was a problem hiding this comment.
Yes please. I find the anonymous class thing quite annoying; these were just the result of copying/moving existing docs.
bertdeblock
force-pushed
the
add-missing-closing-bracket-in-router-service-docs
branch
from
f7d91fe
to
f28818f
Compare
bertdeblock
changed the title
RouterService docsRouterService docs
chriskrycho
approved these changes
Nov 22, 2022
| @@ -454,12 +454,12 @@ class RouterService<R extends Route> extends Service.extend(Evented) { | |||
| import Route from '@ember/routing'; | |||
| import { service } from '@ember/service'; | |||
|
|
|||
| export default class extends Route { | |||
| export default class ContactFormRoute extends Route { | |||
There was a problem hiding this comment.
Yes please. I find the anonymous class thing quite annoying; these were just the result of copying/moving existing docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a few minor improvements along the way if that's okay.