[BUGFIX LTS] Fix runloop types on TS 5.0+ #20398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
approved these changes
Mar 4, 2023
There was a problem hiding this comment.
Oh, totally didn't see this before opening #20400, which I can now close as a duplicate – thank you!
chriskrycho
changed the title
PartialParams type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to microsoft/TypeScript#53080
Edit by @chriskrycho, 2023/03/04: TS 5.0 catches a new assignability error here, and our (very) complicated set of types for
bindand friends got flagged by that. The terminal case forPartialParamsneeds to be a fixed empty tuple rather thannever, so that the type system can see that it will be resolved as 'no arguments' rather than 'nothing' in that scenario.