[BUGFIX stable] Fix type dependency issues #20480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `@simple-dom/interface` and `@glimmer/syntax` to `dependencies` so they are present in the graph for consumers who will not be getting them transitively from the `@glimmer/*` deps which are pre-built into Ember. (Medium-term, it would be preferable for our type emit to roll up these kinds of dependencies the same way Ember's build does *or* for Ember's build to stop rolling them up; whichever we choose, the goal will be for them to *match*.) Fixes #20479.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
@simple-dom/interfaceand@glimmer/syntaxtodependenciesso they are present in the graph for consumers who will not be getting them transitively from the@glimmer/*deps which are pre-built into Ember. (Medium-term, it would be preferable for our type emit to roll up these kinds of dependencies the same way Ember's build does or for Ember's build to stop rolling them up; whichever we choose, the goal will be for them to match.)Fixes #20479.