Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX LTS] Backport some stable type import locations #20481

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

chriskrycho
Copy link
Contributor

The ContainerProxyMixin and RegistryProxyMixin private types are used as "intimate API" by @ember/test-helpers, which aims to support both the preview and stable type definitions. Provide both these types in both their legacy locations (where they were published from until 4.10) and their correct locations. Only provide the types, however, since the runtime location has moved.

The `ContainerProxyMixin` and `RegistryProxyMixin` private types are
used as "intimate API" by `@ember/test-helpers`, which aims to support
both the preview and stable type definitions. Provide both these types
in both their legacy locations (where they were published from until
4.10) and their correct locations. *Only* provide the types, however,
since the runtime location has moved.
@chriskrycho chriskrycho added Bug TypeScript Work on Ember’s types labels Jun 28, 2023
@chriskrycho chriskrycho requested a review from wagenet June 28, 2023 21:28
@chriskrycho chriskrycho merged commit 30b66f3 into lts-4-12 Jun 28, 2023
@chriskrycho chriskrycho deleted the backport-proxy-mixin-type-locations branch June 28, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug TypeScript Work on Ember’s types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants