WIP: Keep a record of stale owners to help better debug poor test isolation

packages/@ember/-internals/container/lib/container.ts

@@ -7,7 +7,7 @@
   FullName,
 } from '@ember/-internals/owner';
 import { setOwner } from '@ember/-internals/owner';
-import { dictionary } from '@ember/-internals/utils';
+import { dictionary, guidFor } from '@ember/-internals/utils';
 import { assert } from '@ember/debug';
 import { DEBUG } from '@glimmer/env';
 import type { DebugRegistry } from './registry';
@@ -53,7 +53,7 @@
 export interface ContainerOptions {
   owner?: InternalOwner;
   cache?: { [key: string]: object };
   factoryManagerCache?: { [key: string]: InternalFactoryManager<any, any> };
   validationCache?: { [key: string]: boolean };
 }
 
@@ -152,7 +152,20 @@
     options?: RegisterOptions
   ): InternalFactory<object> | object | undefined {
     if (this.isDestroyed) {
-      throw new Error(`Cannot call \`.lookup('${fullName}')\` after the owner has been destroyed`);
+      if (macroCondition(isTesting())) {
+        let guid = guidFor(this.owner);
+        // SAFETY: cast is for accessing private data stored globally
+        let testInfo = (globalThis as any)['__OWNER_MAP__']?.get(guid);
+
+        throw new Error(
+          `Cannot call \`.lookup('${fullName}')\` after the owner has been destroyed. ` +
+            `owner is ${guid} (test ${testInfo?.testId} ${testInfo?.name})`
+        );
+      } else {
+        throw new Error(
+          `Cannot call \`.lookup('${fullName}')\` after the owner has been destroyed`
+        );
+      }
     }
     assert('fullName must be a proper full name', this.registry.isValidFullName(fullName));
     return lookup(this, this.registry.normalize(fullName), options);
@@ -201,7 +214,7 @@
   */
   ownerInjection() {
     let injection = {};
     setOwner(injection, this.owner!);
     return injection;
   }
 
@@ -230,7 +243,7 @@
 }
 
 if (DEBUG) {
   Container._leakTracking = leakTracking!;
 }
 
 /*
@@ -261,7 +274,7 @@
     },
   };
 
   return new Proxy(proxiedManager, validator as any) as any;
 }
 
 function isSingleton(container: Container, fullName: FullName) {
@@ -393,8 +406,8 @@
     // if this lookup happened _during_ destruction (emits a deprecation, but
     // is still possible) ensure that it gets destroyed
     if (container.isDestroying) {
       if (typeof (instance as any).destroy === 'function') {
         (instance as any).destroy();
       }
     }
 
@@ -425,7 +438,7 @@
     let value = cache[key];
     assert('has cached value', value);
 
     if ((value as any).destroy) {
       (value as any).destroy();
     }
   }

packages/@ember/-internals/metal/lib/property_set.ts

@@ -1,4 +1,10 @@
-import { lookupDescriptor, setWithMandatorySetter, toString } from '@ember/-internals/utils';
+import { getOwner } from '@ember/-internals/owner';
+import {
+  guidFor,
+  lookupDescriptor,
+  setWithMandatorySetter,
+  toString,
+} from '@ember/-internals/utils';
 import { assert } from '@ember/debug';
 import { DEBUG } from '@glimmer/env';
 import { COMPUTED_SETTERS } from './decorator';
@@ -55,10 +61,23 @@
   );
 
   if ((obj as ExtendedObject).isDestroyed) {
-    assert(
-      `calling set on destroyed object: ${toString(obj)}.${keyName} = ${toString(value)}`,
-      tolerant
-    );
+    if (macroCondition(isTesting())) {
+      let guid = guidFor(getOwner(obj));
+
+      // SAFETY: cast is for accessing private data stored globally
+      let testInfo = (globalThis as any)['__OWNER_MAP__']?.get(guid);
+      assert(
+        `calling set on destroyed object: ${toString(obj)}.${keyName} = ${toString(value)} ` +
+          `owner is ${guid} (test ${testInfo?.testId} ${testInfo?.name})`,
+        tolerant
+      );
+    } else {
+      assert(
+        `calling set on destroyed object: ${toString(obj)}.${keyName} = ${toString(value)}`,
+        tolerant
+      );
+    }
+
     return value;
   }